EmbeddedRelated.com
Forums

HAL for HC12s

Started by hc08jb8 February 15, 2004
A friend from Korea passed me this Hardware Abstraction Layer
implementation for HCS12, thought some folks might find it useful.

http://www.acelab.org/HAL/files.html

Regds
Jay



"hc08jb8" wrote:

>A friend from Korea passed me this Hardware Abstraction Layer
>implementation for HCS12, thought some folks might find it useful.
>
>http://www.acelab.org/HAL/files.html

could anybody else confirm that this is unspeakable bad C code?

I had a really short look at it...

In the ATD stuff: passing pointers to register blocks as uint16,
storing it to a local variable instead of using the parameter itself.

The ATD_Read if/else if... cascade is <censored>.

What does "lock" return: random data?

The EEPROM routine is horrible. Using "for(i=0;i<5000;i++);" for a
delay loop is not acceptable.

Doesn't make use of Doxygen's features, e.g. collecting unimplementes
features in a list. But makes empty "bug" entries.

Are they clueless or did I miss the point?

Oliver
--
Oliver Betz, Muenchen




At 11:03 PM 2/15/04 +0100, you wrote:
>"hc08jb8" wrote:
>I had a really short look at it...
>
Me too....

>In the ATD stuff: passing pointers to register blocks as uint16,
>storing it to a local variable instead of using the parameter itself.
>
>The ATD_Read if/else if... cascade is <censored>.
>
To say nothing of being able to "read" an ADC channel that hasn't been
initialized or started....

You know what they say: Free software is worth every penny you pay for it.
The last company I worked for had a total ban on using freeware or
shareware. This stuff is a good example of why.

Gary Olmstead
Toucan Technology
Ventura CA



Gary Olmstead <> wrote:

[...]

> You know what they say: Free software is worth every penny you pay for it.
> The last company I worked for had a total ban on using freeware or
> shareware. This stuff is a good example of why.

I _strongly_ disagree!

I say that there is little correlation between price and quality.
There is great freeware an shareware, and you can buy expensive crap.

Besides the GNU/Linux systems _most_ of the internet
web/mail/news/etc. servers rely on, I list some of the _free_
software I work with because of it's high quality:

Perl
Java (Sun, not MS)
GNU tools (e.g. unxutils.sourceforge.net or cygwin), like make, wget
Doxygen
AT&T Graphviz (DOT etc.)
VNC remote control software
Ghostscript/Ghostview/GhostWord
Putty
Mozilla
Pegasus Mail (although we paid for, and there are some quirks)

Great Shareware I'm using for the same reason:
NoICE debugger
UltraEdit
Beyond Compare
IrfanView (free for noncommercial use)
PowerArchiver (was even free some day) or Winzip or...
FortAgent
Jacob Navia's "LCC" Compiler (free for noncommercial use)

That's only what I use often - there is much more great and reliable
freeware and shareware.

Maybe you want to reconsider your statement.

Note that I don't say that free or cheap software is always the best
choice. If so, I wouldn't use Cosmic C instead of gcc or PC-Lint
instead of Splint etc.

Oliver
--
Oliver Betz, Muenchen



--- In , Gary Olmstead <garyolmstead@e...> wrote:
> At 11:03 PM 2/15/04 +0100, you wrote:
> >"hc08jb8" wrote:
> >I had a really short look at it...
> >
> Me too....

Hmm, I had a look as well, and their credentials aren't all bad... -----------------
ACE Lab has performed various research projects with local and international companies. On January 6th 2000, ACE Lab and Motorola agreed a ten-year research contract for providing the system solutions of automotive electronic control systems for Korean motor manufacturers and suppliers. Through the agreement, the name of the research lab, ACE Lab, was changed to DigitalDNA ACE Lab. Moreover, DigitalDNA ACE Lab signed a joint research contract with CERT(Center for Environmental Research and Technology) of UCR(University of California-Riverside) which is one of the leading research institutes in the world in the area of automotive emission studies in August 2000. In the year 2001, DigitalDNA ACE Lab has formed a research consortium to perform a ten-year research work of network-based electronic control systems conjunction with Hyundai/Kia Motors, Hyundai MOBIS, KEFICO and NGV. This consortium will focus on the design and development of the next generation control systems until the year 2011:
--------------

Regards,

Theo



--- In , "Oliver Betz" <list_ob@g...> wrote:
> Gary Olmstead <garyolmstead@e...> wrote:

> Besides the GNU/Linux systems _most_ of the internet
> web/mail/news/etc. servers rely on, I list some of the _free_
> software I work with because of it's high quality:

> NoICE debugger

You might get some flack on that one...

Cheers,

Theo



--- In , "Oliver Betz" <list_ob@g...> wrote:

BTW, the hardware looks remakarbly like a T board...

http://www.acelab.org/HAL/index.html

Regards,

Theo



It is indeed the T Board

look up http://www.acelab.org/HAL/README.html

Jay

--- In , "theobee00" <yahoodump2@o...> wrote:
> --- In , "Oliver Betz" <list_ob@g...> wrote:
>
> BTW, the hardware looks remakarbly like a T board...
>
> http://www.acelab.org/HAL/index.html
>
> Regards,
>
> Theo




theobee00 <> wrote:

[bad code from ACE Lab?]

> Hmm, I had a look as well, and their credentials aren't all bad...

I don't care about credentials if I can look at the product. _Did_
you look at the code?

Oliver
--
Oliver Betz, Muenchen



theobee00 wrote:

> > Besides the GNU/Linux systems _most_ of the internet
> > web/mail/news/etc. servers rely on, I list some of the _free_
> > software I work with because of it's high quality:
>
> > NoICE debugger
>
> You might get some flack on that one...

excuse my ignorance, but my dictionary doesn't explain "flack" in a
way that I could understand what you mean.

Oliver
--
Oliver Betz, Muenchen